Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][File] Support skip corrupt files #5590

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Feature][Connector-V2][File] Support skip corrupt files #5590

wants to merge 1 commit into from

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0
Copy link
Member

hailin0 commented Oct 7, 2023

Please check ci error

@Hisoka-X
Copy link
Member

Please add some comment for this.
image

Hisoka-X
Hisoka-X reviewed Oct 10, 2023
View reviewed changes
docs/en/connector-v2/source/CosFile.md Outdated
| sheet_name | string | no | - |
| file_filter_pattern | string | no | - |
| ignore_corrupt_files | boolean | no | true |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default value should be false?

@Hisoka-X
Copy link
Member

Please add test case for this new feature.

@TyrantLucifer
Copy link
Member Author

Please add test case for this new feature.

I will do it at my free time.

@TyrantLucifer TyrantLucifer force-pushed the support-sync-empty-data branch from 6a43e8b to 744f636 Compare November 9, 2023 06:39
@EricJoy2048 EricJoy2048 added this to the 2.3.4 milestone Nov 10, 2023
@EricJoy2048
Copy link
Member

Please fix the CI error

@EricJoy2048 EricJoy2048 removed this from the 2.3.4 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
connectors-v2 file need add test case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TyrantLucifer @hailin0 @Hisoka-X @EricJoy2048