-
Notifications
You must be signed in to change notification settings - Fork 804
SOLR-16736: drop commons-lang3 dependency #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm okay with merging this, however, are there other instances of suppressed uses? I would love it if we could REMOVE the dependency... |
|
I would really love to remove the dependency. Would you be comfortable copying the code to solr? Frankly, I thought of making a fork of commons-lang3 with micro-modules like |
|
I probably am not the right Java person to have an opinion on this... Seems like if that is all we need that "shading" is a thing right? |
|
Please don't remove the JIRA link from the issue template, as it's a convenient link to click as a reviewer. Any way, the code LGTM. |
|
I'm not sure if |
8e35b0e to
c7aa2c3
Compare
c7aa2c3 to
7cf4235
Compare
|
I've completely removed The only missing bit is swagger: |
e4e6719 to
99cfb7a
Compare
|
Note that I went with "forbid commons-lang on the configurations
.matching {
it.name == "compileClasspath" || it.name == "runtimeClasspath"
}
.configureEach {
resolutionStrategy.eachDependency {
if (requested.group == "org.apache.commons" && requested.name == "commons-lang3") {
throw new GradleException(
"Use JDK classes where possible, do not add org.apache.commons:commons-lang3 dependency")
}
}
}So if a transitive dependency selects to depend on commons-lang3, then the validation would trigger. Unfortunately, |
0f44928 to
2c4450c
Compare
|
Spring context fails for some reason. |
2c4450c to
a027beb
Compare
|
There was I've filed:
|
de1c6d9 to
34ec35f
Compare
34ec35f to
de5414b
Compare
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
https://issues.apache.org/jira/browse/SOLR-16736