refactor(caretDown):

- Small adjustments for caret down icon
- Restored menu icons in the header menu

superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx

@@ -104,7 +104,7 @@ const QueryLimitSelect = ({
           <span className="limitDropdown">
             {convertToNumWithSpaces(queryLimit)}
           </span>
-          <Icons.DownOutlined
+          <Icons.CaretDownOutlined
             iconSize="m"
             iconColor={theme.colors.grayscale.base}
           />

superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx

@@ -148,7 +148,7 @@ const RunQueryActionButton = ({
           ? {
               overlay: overlayCreateAsMenu,
               icon: (
-                <Icons.CaretDownOutlined
+                <Icons.DownOutlined
                   iconColor={
                     isDisabled
                       ? theme.colors.grayscale.base

superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx

@@ -49,7 +49,7 @@ const SaveDatasetActionButton = ({
       }
     }
     span[name='caret-down'] {
-      margin-left: ${theme.gridUnit * 1.5}px;
+      margin-left: ${theme.gridUnit * 2}px;
     }
   `;
 
@@ -62,8 +62,8 @@ const SaveDatasetActionButton = ({
       onClick={() => setShowSave(true)}
       overlay={overlayMenu}
       icon={
-        <Icons.CaretDownOutlined
-          iconSize="xl"
+        <Icons.DownOutlined
+          iconSize="m"
           iconColor={theme.colors.grayscale.light5}
           name="caret-down"
         />

superset-frontend/src/components/PopoverDropdown/index.tsx

@@ -110,8 +110,8 @@ const PopoverDropdown = (props: PopoverDropdownProps) => {
     >
       <div role="button" css={{ display: 'flex', alignItems: 'center' }}>
         {selected && renderButton(selected)}
-        <Icons.CaretDownOutlined
-          iconSize="m"
+        <Icons.DownOutlined
+          iconSize="s"
           iconColor={theme.colors.grayscale.base}
           css={{
             marginTop: theme.gridUnit * 0.5,

superset-frontend/src/explore/components/controls/ConditionalFormattingControl/ConditionalFormattingControl.tsx

@@ -182,6 +182,10 @@ const ConditionalFormattingControl = ({
             <Icons.PlusOutlined
               iconSize="xs"
               iconColor={theme.colors.grayscale.light1}
+              css={theme => ({
+                  margin: `auto ${theme.gridUnit * 2}px auto 0`,
+                  verticalAlign: 'baseline',
+                })}
             />
             {t('Add new color formatter')}
           </AddControlLabel>

superset-frontend/src/features/home/LanguagePicker.tsx

@@ -58,14 +58,15 @@ const StyledFlag = styled.i`
 export default function LanguagePicker(props: LanguagePickerProps) {
   const { locale, languages, ...rest } = props;
   return (
+    //TODO remove TriangleDown with ANTD5 icon
     <SubMenu
       aria-label="Languages"
       title={
         <div className="f16">
           <StyledFlag className={`flag ${languages[locale].flag}`} />
         </div>
       }
-      icon={<Icons.CaretDownOutlined />}
+      icon={<Icons.TriangleDown />}
       {...rest}
     >
       {Object.keys(languages).map(langKey => (

superset-frontend/src/features/home/Menu.tsx

@@ -212,7 +212,7 @@ export function Menu({
       <StyledSubMenu
         key={index}
         title={label}
-        icon={showMenu === 'inline' ? <></> : <Icons.CaretDownOutlined />}
+        icon={showMenu === 'inline' ? <></> : <Icons.TriangleDown />}
       >
         {childs?.map((child: MenuObjectChildProps | string, index1: number) => {
           if (typeof child === 'string' && child === '-' && label !== 'Data') {

superset-frontend/src/features/home/RightMenu.tsx

@@ -413,7 +413,7 @@ const RightMenu = ({
                 data-test="new-dropdown-icon"
               />
             }
-            icon={<Icons.CaretDownOutlined />}
+            icon={<Icons.TriangleDown  />}
           >
             {dropdownItems?.map?.(menu => {
               const canShowChild = menu.childs?.some(
@@ -473,7 +473,8 @@ const RightMenu = ({
             })}
           </StyledSubMenu>
         )}
-        <StyledSubMenu title={t('Setting')} icon={<Icons.CaretDownOutlined />}>
+         {/* TODO replace TriangleDown with ANTD5 icons */ }
+        <StyledSubMenu title={t('Setting')} icon={<Icons.TriangleDown  />}>
           {settings?.map?.((section, index) => [
             <Menu.ItemGroup key={`${section.label}`} title={section.label}>
               {section?.childs?.map?.(child => {

superset-frontend/src/features/home/SubMenu.tsx

@@ -231,10 +231,11 @@ const SubMenuComponent: FunctionComponent<SubMenuProps> = props => {
         <div className={navRightStyle}>
           <Menu mode="horizontal" triggerSubMenuAction="click" disabledOverflow>
             {props.dropDownLinks?.map((link, i) => (
+              // TODO remove TriangleDown with ANTD5 icon
               <SubMenu
                 key={i}
                 title={link.label}
-                icon={<Icons.CaretDownOutlined />}
+                icon={<Icons.TriangleDown />}
                 popupOffset={[10, 20]}
                 className="dropdown-menu-links"
               >