-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Relax][Torch] Fix from_exported_program crash with FakeTensor and lifted tensors #18540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…fted tensors Fix Issue apache#18407: from_exported_program segfault with exported MHA using eq(0)/expand mask + in-place masked_fill_. Problem: When importing torch.export models with lifted tensors (e.g., from masked_fill_ operations), the conversion fails because these tensors are FakeTensor or tensor subclasses that don't support .numpy() or DLPack conversion. Solution: - Add FakeTensor detection before conversion - Create zero tensors as placeholders for FakeTensor/lifted tensors - Add fallback exception handling for tensor subclasses - Use torch.zeros instead of torch.randn to support all dtypes This fix allows models with MHA and masked_fill_ operations to be successfully imported without crashes.
Summary of ChangesHello @Dayuxiaoshui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue where importing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a crash when importing torch.export models that contain FakeTensor or other lifted tensor subclasses. The changes introduce checks to identify these special tensors and replace them with zero-filled placeholder tensors, preventing failures during conversion to TVM tensors. My review focuses on improving the readability and robustness of these new checks.
a67b780 to
4091ec7
Compare
tlopex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a test for it?
9610a23 to
5228cc3
Compare
|
@tlopex Fixed (with testing caveat) Fix implemented: Modified Testing issue: The exact model from the issue report triggers a PyTorch segfault during Verification: The fix has been validated with simplified test cases and works correctly for scenarios where PyTorch export succeeds. |
|
cc @tlopex |
Fix Issue #18407: from_exported_program segfault with exported MHA using eq(0)/expand mask + in-place masked_fill_.
Problem:
When importing torch.export models with lifted tensors (e.g., from masked_fill_ operations), the conversion fails because these tensors are FakeTensor or tensor subclasses that don't support .numpy() or DLPack conversion.
Solution:
This fix allows models with MHA and masked_fill_ operations to be successfully imported without crashes.