chore!: move from yargs to node:util#871
Merged
vladfrangu merged 11 commits intomasterfrom Aug 6, 2025
Merged
Conversation
B4nan
approved these changes
Aug 5, 2025
Member
B4nan
left a comment
There was a problem hiding this comment.
now that's a lot of changes, this will need proper testing once the canary is released
| }), | ||
| 'input-file': Flags.string({ | ||
| aliases: ['if'], | ||
| char: 'f', |
Member
There was a problem hiding this comment.
this looks like a BC, should be noted somewhere
Member
Author
There was a problem hiding this comment.
Yeah... I'd add it to the commit description when we merge this
sorry past me, this is why you double check your double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The shorthand flag for
--input-filein thecallcommand has been changed from-ifto-f.Closes #833, by moving our argument parsing from yargs to the built-in one from nodejs. This does come with some caveats (specifically aliases like
-ifwill be interpreted as setting the flags-iand-f(if both are defined) or asfas the value of the-iflag.).For most use cases, there should be 0 difference in how flags and args are parsed and it should all work. From initial testing, even stdin input just worked