Skip to content

Unify separators in unique_key construction (| vs _) #1512

Closed

Description

@vdusek

Description

We currently construct parts of the unique_key using the pipe (|) as a separator.
For example, a standard (extended) unique_key looks like this:

unique_key='GET|e3b0c442|e3b0c442|https://crawlee.dev/'

However, for the always_enqueue feature, we append a random alphanumeric suffix using an underscore (_) instead of a pipe:

if always_enqueue:
    unique_key = f'{unique_key}_{crypto_random_object_id()}'

Resulting in:

unique_key='GET|e3b0c442|e3b0c442|https://crawlee.dev/_7VnDVJgE3TrjbDl86'

Proposed change

Use the pipe (|) consistently as a separator throughout all unique_key constructions, including the always_enqueue case.

Note

This change affects the resulting unique_key format and may be breaking, so it should be addressed as part of the next major release (v2.0).

Activity

  1. added
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Oct 22, 2025
  2. added this to the 2.0 milestone on Oct 22, 2025
  3. self-assigned this
    on Nov 18, 2025
  4. vdusek commented on Nov 18, 2025

    @vdusek
    CollaboratorAuthor

    Since this proposal changes only the unique keys of the always_enqueue request, it is not a breaking change.

  5. removed this from the 2.0 milestone on Nov 18, 2025
  6. added a commit that references this issue on Nov 18, 2025
    b294e96
  7. added a commit that references this issue on Nov 18, 2025
    af46a37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions