Skip to content

Add support for preNavigationHooks in Playwright #427

Closed

Description

@viewv

As the title, I want to know does the crawlee-python support the preNavigationHooks function?

Activity

  1. added
    enhancementNew feature or request.
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Aug 13, 2024
  2. janbuchar commented on Aug 13, 2024

    @janbuchar
    Collaborator

    Hello and thanks for your interest in Crawlee for Python! Pre-navigation hooks are not currently supported. Before we implement this, would putting the hook code into the request handler help? Or do you need to do something before the page is loaded?

  3. viewv commented on Aug 13, 2024

    @viewv
    Author

    Hello and thanks for your interest in Crawlee for Python! Pre-navigation hooks are not currently supported. Before we implement this, would putting the hook code into the request handler help? Or do you need to do something before the page is loaded?

    OK, thank you, I want to change some browser properties before the page loaded, so I think it will be really helpful to support the preNavigationHooks.

  4. Tallone commented on Aug 23, 2024

    @Tallone

    I want to do something before the page loads, such as aborting when loading some images or CSS, Is there any trick available to achieve this as of now?

  5. vdusek commented on Sep 25, 2024

    @vdusek
    Collaborator

    Implementation from Crawlee JS:

  6. changed the title [-]Does the crawlee-python supports preNavigationHooks?[/-] [+]Add support for `preNavigationHooks` in Playwright[/+] on Sep 25, 2024
  7. Yashwanth-Chandrakumar commented on Oct 18, 2024

    @Yashwanth-Chandrakumar

    @vdusek /assign

  8. janbuchar commented on Oct 18, 2024

    @janbuchar
    Collaborator

    @vdusek /assign

    We don't assign issues for hacktoberfest. If you want to contribute, open a PR whenever you're ready. First mergeable one gets merged.

  9. Yashwanth-Chandrakumar commented on Oct 18, 2024

    @Yashwanth-Chandrakumar

    @janbuchar Thanks Mate

  10. Yashwanth-Chandrakumar commented on Oct 19, 2024

    @Yashwanth-Chandrakumar

    @janbuchar i have created a PR to solve the issue please view it #602

  11. added a commit that references this issue on Oct 30, 2024
    5dd5b60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request.hacktoberfestt-toolingIssues with this label are in the ownership of the tooling team.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions