You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we should consider also making this a method of the kv-store resource client and implementing it separately for memory storage and for platform storage in SDK
when this is done, update the deployment/apify-platform docs page (there is commented out doc for this feature)
I think we need to add some checks and better handling of errors. First, we should make sure that the key and **storeName** are valid before trying to generate a URL. Depending on whether we’re using memory storage or platform storage, we handle them differently: for memory storage, we can return a local URL **(like localhost)**, but we need to be aware that this might not be publicly accessible. For platform storage, we should create a URL that fits the platform’s format. If the **storageType** is unknown, we throw an error so the issue is clear. Wrapping everything in try-catch helps us catch any unexpected problems and log useful error messages, making the code more reliable.
Activity
ravi-hash commentedon Oct 2, 2024
Hey will you assign this issue to me
nehaaprasad commentedon Oct 3, 2024
Hello! @janbuchar :)
I think we need to add some checks and better handling of errors. First, we should make sure that the key and **storeName** are valid before trying to generate a URL. Depending on whether we’re using memory storage or platform storage, we handle them differently: for memory storage, we can return a local URL **(like localhost)**, but we need to be aware that this might not be publicly accessible. For platform storage, we should create a URL that fits the platform’s format. If the **storageType** is unknown, we throw an error so the issue is clear. Wrapping everything in try-catch helps us catch any unexpected problems and log useful error messages, making the code more reliable.janbuchar commentedon Oct 3, 2024
Hello @ravi-hash and @naaa760, we will accept a PR from whomever finishes it first, no need to have it assigned first.
feat: Added get_public_url method to KeyValueStore (apify#572)