Skip to content

Implement KeyValueStore.get_public_url #514

Closed

Description

@janbuchar

Activity

  1. added
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Sep 10, 2024
  2. ravi-hash commented on Oct 2, 2024

    @ravi-hash

    Hey will you assign this issue to me

  3. nehaaprasad commented on Oct 3, 2024

    @nehaaprasad

    Hello! @janbuchar :)

    I think we need to add some checks and better handling of errors. First, we should make sure that the key and **storeName** are valid before trying to generate a URL. Depending on whether we’re using memory storage or platform storage, we handle them differently: for memory storage, we can return a local URL **(like localhost)**, but we need to be aware that this might not be publicly accessible. For platform storage, we should create a URL that fits the platform’s format. If the **storageType** is unknown, we throw an error so the issue is clear. Wrapping everything in try-catch helps us catch any unexpected problems and log useful error messages, making the code more reliable.

  4. janbuchar commented on Oct 3, 2024

    @janbuchar
    CollaboratorAuthor

    Hello @ravi-hash and @naaa760, we will accept a PR from whomever finishes it first, no need to have it assigned first.

  5. added a commit that references this issue on Oct 22, 2024
    3a4ba8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request.hacktoberfestt-toolingIssues with this label are in the ownership of the tooling team.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions