Skip to content

Simplify argument type requests #98

Closed

Description

@vdusek

Somewhere we use the following:

requests: list[BaseRequestData | Request]

Let's refactor the code to accept only one type.

On the places where we need to use:

arg_name: list[Request | str]

Let's use a different identifier than requests, e.g. sources.

See the following conversation for context - #56 (comment).

Activity

  1. added
    t-toolingIssues with this label are in the ownership of the tooling team.
    debtCode quality improvement or decrease of technical debt.
    on Apr 9, 2024
  2. janbuchar commented on Apr 9, 2024

    @janbuchar
    Collaborator

    The RequestProvider interface is the place.

  3. self-assigned this
    on Jun 17, 2024
  4. added a commit that references this issue on Nov 14, 2024
    f8f4066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

debtCode quality improvement or decrease of technical debt.t-toolingIssues with this label are in the ownership of the tooling team.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions