Skip to content

fix: Add storages name validation - #1457

Merged
vdusek merged 6 commits into
apify:masterfrom
Mantisus:fix-storage-name
Oct 7, 2025
Merged

vdusek merged 6 commits into
apify:masterfrom
Mantisus:fix-storage-name

Conversation

@Mantisus

@Mantisus Mantisus commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Added name validation for storages in accordance with Apify platform restrictions

Issues

Testing

  • Added new tests to verify correct validation.

@Mantisus
Mantisus requested review from Pijukatel and vdusek and removed request for vdusek October 6, 2025 16:29
@Mantisus Mantisus self-assigned this Oct 6, 2025
@Mantisus
Mantisus requested a review from vdusek October 6, 2025 16:29
@vdusek
vdusek requested review from janbuchar and removed request for Pijukatel October 7, 2025 07:59
@vdusek

vdusek commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

assigning @janbuchar as @Pijukatel is off for this week

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?

Comment thread src/crawlee/storages/_base.py Resolved
Comment thread tests/unit/storages/test_dataset.py Resolved
Mantisus and others added 2 commits October 7, 2025 15:10
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@Mantisus
Mantisus requested a review from vdusek October 7, 2025 12:22
@vdusek

vdusek commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

@Mantisus sorry did you overlook this:

Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?

What do you think about that?

@Mantisus

Mantisus commented Oct 7, 2025 •

Copy link
Copy Markdown
Collaborator Author

Sorry, yes

What do you think about that?

I'm not sure, because it's a fix. And we didn't include fixes in the upgrading guide, if I'm not mistaken.

@Mantisus

Mantisus commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator Author

The upgrading guide was updated after discussing on Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate storage names before passing them to the storage client

3 participants