Repository navigation
chore: improve HttpClient isolating in tests - #1513
Merged
Merged
Conversation
HttpClient isolate in tests
HttpClient isolate in testsHttpClient isolating in tests
Collaborator
Author
|
It seems to be working. Several test runs failed, but this is not related to |
Pijukatel
reviewed
Oct 24, 2025
Pijukatel
left a comment
Collaborator
There was a problem hiding this comment.
Can you please remove the skip from these tests to see if it works on them as well?
test_sitemap.test_gzipped_sitemap_with_invalid_data
test_http_clients.test_stream
Pijukatel
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
test_gz_sitemap_with_non_gzippedis flaky #1460