Skip to content

fix: crawlee local storage dir environment variable name - #270

Closed
janbuchar wants to merge 3 commits into
masterfrom
fix-local-storage-env-var-name
Closed

janbuchar wants to merge 3 commits into
masterfrom
fix-local-storage-env-var-name

Conversation

@janbuchar

Copy link
Copy Markdown
Collaborator

No description provided.

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 6, 2024
@janbuchar
janbuchar requested review from B4nan and vdusek July 6, 2024 12:40
@github-actions github-actions Bot added this to the 93rd sprint - Tooling team milestone Jul 6, 2024
@janbuchar janbuchar linked an issue Jul 6, 2024 that may be closed by this pull request
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jul 7, 2024
def test_persist_storage_set_to_false_via_string_env_var(monkeypatch: pytest.MonkeyPatch, tmp_path: Path) -> None:
monkeypatch.setenv('CRAWLEE_PERSIST_STORAGE', 'false')
ms = MemoryStorageClient(Configuration(crawlee_local_storage_dir=str(tmp_path))) # type: ignore
ms = MemoryStorageClient(Configuration.model_validate({'local_storage_dir': str(tmp_path)}))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be also crawlee_storage_dir? or maybe just storage_dir? the "config option" should be just storage_dir i think (we don't have one in the JS version and only deal with this in the call sites)

@B4nan B4nan closed this Jul 8, 2024
@janbuchar
janbuchar deleted the fix-local-storage-env-var-name branch January 31, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRAWLEE_LOCAL_STORAGE_DIR should be called just CRAWLEE_STORAGE_DIR

2 participants