Skip to content

bug: minor log fix - #341

Merged
janbuchar merged 2 commits into
masterfrom
log-fix
Jul 22, 2024
Merged

janbuchar merged 2 commits into
masterfrom
log-fix

Conversation

@souravjain540

@souravjain540 souravjain540 commented Jul 22, 2024 •

Copy link
Copy Markdown
Collaborator

Description

wrong command in the log: 'pip install crawlee[playwright]', it should be "pip install 'crawlee[playwright]'"

Issues

  • N/A

Testing

  • N/A

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@souravjain540
souravjain540 requested a review from vdusek July 22, 2024 04:00
@vdusek

vdusek commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator
  • I understand the reasoning behind using single quotes around the package name with the extra, as it helps with shell compatibility when dealing with brackets.
  • The backticks... Since this is just a log line without any formatting, I'm unsure whether using backticks (`) isn't just less readable.

What do you think @janbuchar?

@janbuchar janbuchar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdusek I think the backticks are fine. We may want to use colors instead at some point, but there's no need to stall such a minor PR because of that.

Comment thread src/crawlee/browsers/__init__.py Resolved
Co-authored-by: Jan Buchar <jan.buchar@apify.com>

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar
janbuchar merged commit 0688bf1 into master Jul 22, 2024
@janbuchar
janbuchar deleted the log-fix branch July 22, 2024 13:41
@B4nan

B4nan commented Jul 23, 2024

Copy link
Copy Markdown
Member

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

@janbuchar

Copy link
Copy Markdown
Collaborator

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

I mean, we can update the log generator to put bug: in the same bucket as fix:

@souravjain540

souravjain540 commented Jul 23, 2024 •

Copy link
Copy Markdown
Collaborator Author

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

Hehehe, sorry!

@B4nan

B4nan commented Jul 23, 2024

Copy link
Copy Markdown
Member

I mean, we can update the log generator to put bug: in the same bucket as fix:

or we can actually follow the specs and not use random prefixes like bug: :D

@B4nan

B4nan commented Jul 23, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants