Repository navigation
feat: add new curl impersonate HTTP client - #387
Merged
Merged
Conversation
vdusek
force-pushed
the
add-curl-cffi-client
branch
from
August 1, 2024 15:36
2a8a909 to
179c965
Compare
Contributor
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
Contributor
|
Hello.Great effort so far. Is the |
Collaborator
Author
|
@siddiqkaithodu Hey, good point, I'll expose kwargs for the |
janbuchar
reviewed
Aug 2, 2024
|
|
||
| class HttpxClient(BaseHttpClient): | ||
| """A httpx-based HTTP client used for making HTTP calls in crawlers (`BasicCrawler` subclasses).""" | ||
| class HttpxHttpClient(BaseHttpClient): |
Collaborator
There was a problem hiding this comment.
I mean... does this really contain more information now?
Collaborator
Author
There was a problem hiding this comment.
I was just following the pattern of using "library name" + "HttpClient" as a suffix for consistency, even though it doesn't add much information in this particular case.
janbuchar
requested changes
Aug 2, 2024
janbuchar
self-requested a review
August 2, 2024 16:31
janbuchar
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
curl-cffi, opening issues:RequestsError400 lexiforest/curl_cffi#361basic_crawlermodule to the root of the package. Maybe it's not good, so I am open to other options on how to sort it out.Issues
curl-cffi#292Testing
TODO
Checklist