Skip to content

fix: fix circular import in KeyValueStore - #805

Merged
janbuchar merged 1 commit into
apify:masterfrom
Mantisus:circular-fix
Dec 11, 2024
Merged

janbuchar merged 1 commit into
apify:masterfrom
Mantisus:circular-fix

Conversation

@Mantisus

Copy link
Copy Markdown
Collaborator

Description

  • Fix circular imports occurring after using service_container in KeyValueStore

Issues

Checklist

  • CI passed

@Mantisus

Copy link
Copy Markdown
Collaborator Author

It's strange that the tests didn't indicate that there was a problem with imports.

Thank you @Pijukatel for noticing that.

@janbuchar
janbuchar merged commit 8bdf49d into apify:master Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular dependnency on from crawlee.storages import Dataset

3 participants