Add log_every_n_steps in training #523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyin94
commented
Jun 17, 2024
| @@ -150,6 +150,9 @@ class Config(Module.Config): | |||
| # An optional recorder for measuring common metrics like step time. | |||
| recorder: Optional[InstantiableConfig[measurement.Recorder]] = None | |||
|
|
|||
| # The frequency of logging during training. | |||
| log_every_n_steps: Optional[int] = None | |||
There was a problem hiding this comment.
did not set log_every_n_steps: int = 100 to avoid a large amount of config.txt update. If we think it makes more sense, we can also change it
4268b70 to
08dfc09
Compare
ruomingp
reviewed
Jun 24, 2024
| @@ -150,6 +150,9 @@ class Config(Module.Config): | |||
| # An optional recorder for measuring common metrics like step time. | |||
| recorder: Optional[InstantiableConfig[measurement.Recorder]] = None | |||
|
|
|||
| # The frequency of logging during training. By default, it will use 100. | |||
| log_every_n_steps: Optional[int] = None | |||
There was a problem hiding this comment.
How about taking a function config instead of an int? This will allow users to set
cfg.logging_steps = config_for_function(every_n_steps).set(n=100, additional=list(range(5)) + [max_step])
There was a problem hiding this comment.
I think I would prefer a simple int for my use case of printing step time every step.
There was a problem hiding this comment.
Maybe both a function and a simple int are allowed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: