Adds convert_dense_to_moe_parameters .
#584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4da0333 to
337e90e
Compare
convert_dense_to_sparse_parameters.convert_dense_to_moe_parameters .
qdavid1
pushed a commit
to qdavid1/axlearn
that referenced
this pull request
Dec 11, 2024
* Adds `convert_dense_to_sparse_parameters`. * Adds `convert_dense_to_moe_parameters`. * Removes `target_layer` from the args of `convert_dense_to_moe_parameters`. * Makes `convert_dense_to_moe_parameters` use pjit to get the right target sharding. * Adds comments to `convert_dense_to_moe_parameters`. * Simplifies the conversion logic. * Use `einsum` instead of `tile` to replicate the dense weights to MoE ones. * Adds testing that the dense weights are replicated to each expert. * Adds explicit sharding constraint on the dispatch tensor. * Addresses Xianzhi's review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to support upcycling of dense to MoE models.