Support customized mesh rules to support different HWs #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markblee
reviewed
Sep 11, 2024
markblee
reviewed
Sep 12, 2024
axlearn/common/utils.py
Outdated
| @@ -102,6 +105,26 @@ def sharding(self) -> jax.sharding.Sharding: | |||
| NestedTensorSpec = Optional[Union[TensorSpec, dict[str, Any]]] | |||
|
|
|||
|
|
|||
| def offload_dots_saveble(offload_src, offload_dst): | |||
| """Extract and combine the policy from save_and_offload_only_these_names and dots_saveable. | |||
There was a problem hiding this comment.
Is this accurate? Seems that dots_saveable includes lax_convolution.conv_general_dilated_p. Also clarify how it combines save_and_offload_only_these_names ?
There was a problem hiding this comment.
Updated comments, the reference is actually a bit different from dots_saveable.
markblee
approved these changes
Sep 13, 2024
| @@ -0,0 +1,180 @@ | |||
| # Copyright © 2023 Apple Inc. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright © 2023 Apple Inc. | |
| # Copyright © 2024 Apple Inc. |
(here and elsewhere)
There was a problem hiding this comment.
Done. Thanks for the review, I need one more approval after the nit change.
markblee
approved these changes
Sep 13, 2024
qdavid1
pushed a commit
to qdavid1/axlearn
that referenced
this pull request
Dec 11, 2024
* cherrypick from internal PR change * snapshot * nit comment fixes * address Mark's comments * snapshot * fix the wrong name * snapshot * nit type format * snasphot * snasphot * remove white space * nit format fix * fix some minor annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few system only mesh config modifiers, including
Also added v5e fuji-7B numbers for the record.