Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feedforward remat point #864

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix feedforward remat point #864

merged 1 commit into from
Dec 2, 2024
+445 −461

Conversation

hanzhi713
Copy link
Member

@hanzhi713 hanzhi713 commented Dec 2, 2024 •
edited
Loading

Also improve build_remat_spec to use regex.

image

@hanzhi713 hanzhi713 added this pull request to the merge queue Dec 2, 2024
Merged via the queue into apple:main with commit 2f7291c Dec 2, 2024
10 checks passed
@hanzhi713 hanzhi713 deleted the fix_remat branch December 2, 2024 21:41
qdavid1 pushed a commit to qdavid1/axlearn that referenced this pull request Dec 11, 2024
@hanzhi713 @qdavid1
Fix feedforward remat point (apple#864)
62e8e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomingp ruomingp ruomingp approved these changes

@samos123 samos123 samos123 approved these changes

@markblee markblee Awaiting requested review from markblee markblee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzhi713 @samos123 @ruomingp