MaskFnAttentionBias._bool_value passes the same rank position tensors to mask_fn. #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From 950 |
apghml
requested changes
Dec 12, 2024
|
Hi, could you take a look? From 950 |
ruomingp
approved these changes
Dec 17, 2024
… to mask_fn. When target_positions is set, a rank 3 target_positions and a rank 2 source_positions are passed to mask_fn. From the perspective of a downstream defining mask_fn, this is a big surprise.
|
Thank you for review! |
apghml
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaskFnAttentionBias._bool_value passes the same rank position tensors to mask_fn.
When target_positions is set, a rank 3 target_positions and a rank 2
source_positions are passed to mask_fn. From the perspective of a downstream
defining mask_fn, this is a big surprise.