forked from sst/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add elapsed runtime display for in-progress TUI commands #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ariane-emory
wants to merge
28
commits into
dev
Choose a base branch
from
feat/elapsed-timer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display elapsed time for active assistant messages in TUI - Timer starts from user message creation time and updates every second - Elapsed time shown next to agent mode and model info - Timer automatically cleans up when message completes or component unmounts - Addresses part 1 of issue sst#5872: elapsed runtime visibility Changes: - Added onCleanup import for timer cleanup - Added elapsedTime signal with createEffect timer logic - Updated AssistantMessage display logic to show elapsed time for in-progress messages - Maintains existing duration display for completed messages
- Add props.last check to timer guard so only the last assistant message runs the elapsed time interval - Fix Match condition that was always true (final() || !final()) - Remove accidentally committed binary build file
… message time - Change timer to show elapsed time since the current tool call/text part started - Add 'running' label to distinguish in-progress elapsed time from completed duration - Timer now resets for each new action, showing how long the current operation takes - Falls back to user message time if no part timing info is available
Prevent timer from flip-flopping between total conversation time and current operation time. Timer now only displays when there's an actively running part with proper timing information. - Removes fallback to user.time.created when no running part found - Timer hides between operations instead of showing incorrect times - Also reorders package.json dependencies alphabetically
… into feat/elapsed-timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.
Changes: