Patch/keybindable commands with nonfatal missing key commands #61
+69
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change keybinds schema from .strict() to .passthrough() to allow unknown keybind names - Track invalid keybinds separately from valid ones in keybind context - Show warning toast when unknown keybind is pressed: 'No command <name>' - Add ValidKeybindNames export to identify valid vs invalid keybinds - Add tests for unknown keybind handling and ValidKeybindNames Fixes issue where unknown keybinds caused fatal startup errors.
…ands-with-nonfatal-missing-key-commands
…mmands' of github.com:ariane-emory/opencode into patch/keybindable-commands-with-nonfatal-missing-key-commands
…mmands' of github.com:ariane-emory/opencode into patch/keybindable-commands-with-nonfatal-missing-key-commands
31c0ded to
d6393fe
Compare
…mmands' of github.com:ariane-emory/opencode into patch/keybindable-commands-with-nonfatal-missing-key-commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DUMMY PR, IGNORE.