Merged
Conversation
arkq
approved these changes
Jun 29, 2022
Owner
arkq
left a comment
There was a problem hiding this comment.
Could you also add information to the README that dependencies are read from project section of pyproject.toml (in a similar way poetry is mentioned)? Also, please bump version to 1.6.0 (github actions will release new package after merging to master).
Conform variable name for pep621 toml to existing code.
arkq
reviewed
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading project name, dependencies, and extras using PEP 621 metadata in pyproject.toml. Setuptools added support in v61.0.0, many other pypa build tools have supported it for a while (flit, hatch, pdm, enscons that I know of), and poetry will (eventually) support it in v2.
I based the additions and tests on the existing ones for poetry, since they're pretty similar. Hopefully I didn't miss anything, but I'm happy to make adjustments if needed/desired.