Re-enable scheduled app unit test (TestSyncScheduledSparkApplication_…

…Forbid) (kubeflow#865) * Fix scheduled app test * fix typo Co-authored-by: Thi Nguyen <[email protected]> Co-authored-by: Thi Nguyen <[email protected]>
arpit1997 · Apr 9, 2020 · 2e4559e · 2e4559e
1 parent e1d70af
commit 2e4559e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pkg/controller/scheduledsparkapplication/controller.go b/pkg/controller/scheduledsparkapplication/controller.go
@@ -249,6 +249,7 @@ func (c *Controller) createSparkApplication(
 		Name:       scheduledApp.Name,
 		UID:        scheduledApp.UID,
 	})
+	app.ObjectMeta.Namespace = scheduledApp.Namespace
 	app.ObjectMeta.Labels = make(map[string]string)
 	for key, value := range scheduledApp.Labels {
 		app.ObjectMeta.Labels[key] = value

diff --git a/pkg/controller/scheduledsparkapplication/controller_test.go b/pkg/controller/scheduledsparkapplication/controller_test.go
@@ -176,9 +176,6 @@ func TestSyncScheduledSparkApplication_Allow(t *testing.T) {
 }
 
 func TestSyncScheduledSparkApplication_Forbid(t *testing.T) {
-	// TODO: figure out why the test fails and remove this.
-	t.Skip()
-
 	app := &v1beta2.ScheduledSparkApplication{
 		ObjectMeta: metav1.ObjectMeta{
 			Namespace: "default",