fix assignment case

astral-sh · Oct 17, 2023 · 551ad16 · 551ad16
1 parent df6adf8
commit 551ad16
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/crates/ruff_linter/resources/test/fixtures/pylint/unnecessary_list_index_lookup.py b/crates/ruff_linter/resources/test/fixtures/pylint/unnecessary_list_index_lookup.py
@@ -3,3 +3,5 @@
 for index, letter in enumerate(letters):
     print(letters[index])  # PLR1736
     blah = letters[index]  # PLR1736
+    letters[index] = letters[index]  # PLR1736 (on the right hand)
+    letters[index] = "d"  # Ok
diff --git a/crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_index_lookup.rs b/crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_index_lookup.rs
@@ -1,4 +1,4 @@
-use ruff_python_ast::{self as ast, Expr, StmtFor};
+use ruff_python_ast::{self as ast, Expr, Stmt, StmtFor};
 
 use ruff_diagnostics::{AlwaysFixableViolation, Diagnostic, Edit, Fix};
 use ruff_macros::{derive_message_formats, violation};
@@ -81,6 +81,15 @@ impl<'a> Visitor<'_> for SubscriptVisitor<'a> {
             _ => visitor::walk_expr(self, expr),
         }
     }
+
+    fn visit_stmt(&mut self, stmt: &Stmt) {
+        match stmt {
+            Stmt::Assign(ast::StmtAssign { value, .. }) => {
+                self.visit_expr(value);
+            }
+            _ => visitor::walk_stmt(self, stmt),
+        }
+    }
 }
 
 /// PLR1736

diff --git a/...napshots/ruff_linter__rules__pylint__tests__PLR1736_unnecessary_list_index_lookup.py.snap b/...napshots/ruff_linter__rules__pylint__tests__PLR1736_unnecessary_list_index_lookup.py.snap
@@ -7,6 +7,7 @@ unnecessary_list_index_lookup.py:4:11: PLR1736 [*] Unnecessary list index lookup
 4 |     print(letters[index])  # PLR1736
   |           ^^^^^^^^^^^^^^ PLR1736
 5 |     blah = letters[index]  # PLR1736
+6 |     letters[index] = letters[index]  # PLR1736 (on the right hand)
   |
   = help: Remove unnecessary list index lookup
 
@@ -17,13 +18,17 @@ unnecessary_list_index_lookup.py:4:11: PLR1736 [*] Unnecessary list index lookup
 4   |-    print(letters[index])  # PLR1736
   4 |+    print(letter)  # PLR1736
 5 5 |     blah = letters[index]  # PLR1736
+6 6 |     letters[index] = letters[index]  # PLR1736 (on the right hand)
+7 7 |     letters[index] = "d"  # Ok
 
 unnecessary_list_index_lookup.py:5:12: PLR1736 [*] Unnecessary list index lookup
   |
 3 | for index, letter in enumerate(letters):
 4 |     print(letters[index])  # PLR1736
 5 |     blah = letters[index]  # PLR1736
   |            ^^^^^^^^^^^^^^ PLR1736
+6 |     letters[index] = letters[index]  # PLR1736 (on the right hand)
+7 |     letters[index] = "d"  # Ok
   |
   = help: Remove unnecessary list index lookup
 
@@ -33,5 +38,25 @@ unnecessary_list_index_lookup.py:5:12: PLR1736 [*] Unnecessary list index lookup
 4 4 |     print(letters[index])  # PLR1736
 5   |-    blah = letters[index]  # PLR1736
   5 |+    blah = letter  # PLR1736
+6 6 |     letters[index] = letters[index]  # PLR1736 (on the right hand)
+7 7 |     letters[index] = "d"  # Ok
+
+unnecessary_list_index_lookup.py:6:22: PLR1736 [*] Unnecessary list index lookup
+  |
+4 |     print(letters[index])  # PLR1736
+5 |     blah = letters[index]  # PLR1736
+6 |     letters[index] = letters[index]  # PLR1736 (on the right hand)
+  |                      ^^^^^^^^^^^^^^ PLR1736
+7 |     letters[index] = "d"  # Ok
+  |
+  = help: Remove unnecessary list index lookup
+
+ℹ Fix
+3 3 | for index, letter in enumerate(letters):
+4 4 |     print(letters[index])  # PLR1736
+5 5 |     blah = letters[index]  # PLR1736
+6   |-    letters[index] = letters[index]  # PLR1736 (on the right hand)
+  6 |+    letters[index] = letter  # PLR1736 (on the right hand)
+7 7 |     letters[index] = "d"  # Ok