Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] - add unnecessary-list-index-lookup (PLR1736) + autofix #7999

Merged
merged 20 commits into from
Nov 30, 2023
Merged

[pylint] - add unnecessary-list-index-lookup (PLR1736) + autofix #7999

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
76e178a
add PLR1736 and autofix
diceroll123 Oct 17, 2023
a0c3a57
fix assignment case
diceroll123 Oct 17, 2023
f24c92d
ignore rule when underscore is used as a variable
diceroll123 Oct 17, 2023
87ac940
add the other assignments
diceroll123 Oct 18, 2023
26e9968
add generator/compehrension expressions
diceroll123 Oct 20, 2023
6a041fa
tweak logic for assignments
diceroll123 Nov 4, 2023
85f4c44
fix lint code order
diceroll123 Nov 24, 2023
801aca5
update snapshots
diceroll123 Nov 24, 2023
1aa0024
Update crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_ind…
diceroll123 Nov 28, 2023
0dc64eb
Update crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_ind…
diceroll123 Nov 28, 2023
6f7f90d
Update crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_ind…
diceroll123 Nov 28, 2023
33bdba8
Update crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_ind…
diceroll123 Nov 28, 2023
502f543
Update ruff_linter__rules__pylint__tests__PLR1736_unnecessary_list_in…
diceroll123 Nov 28, 2023
d0e2f19
tweak modification detection
diceroll123 Nov 28, 2023
fc43d1b
update fixture
diceroll123 Nov 28, 2023
bcae782
use `checker.semantic().resolve_call_path`
diceroll123 Nov 28, 2023
267a10b
add case for deletions
diceroll123 Nov 28, 2023
a6502b4
fix comments
diceroll123 Nov 28, 2023
59fec72
suggested tweaks
diceroll123 Nov 30, 2023
a0a3688
Merge branch 'main' into add-R1736
diceroll123 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_ind… 
…ex_lookup.rs

Co-authored-by: Zanie Blue <[email protected]>
  • Loading branch information
@diceroll123 @zanieb
diceroll123 and zanieb authored Nov 28, 2023
commit 33bdba85cc18aca266f5fdc64fe32f5139195788
2 changes: 1 addition & 1 deletion crates/ruff_linter/src/rules/pylint/rules/unnecessary_list_index_lookup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use ruff_text_size::TextRange;
use crate::checkers::ast::Checker;

/// ## What it does
/// Checks for uses of enumeration and accessing the value by index lookup.
/// Checks for access of a list item at the current index when using enumeration.
///
/// ## Why is this bad?
/// It is more succinct to use the variable for the value at the current index which is already in scope from the iterator.
Expand Down
Loading