[flake8-bandit] Implement S502 SslInsecureVersion rule
#9390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdegraaf
commented
Jan 4, 2024
Comment on lines
65
to
68
| _ => vec!["ssl_version", "method"], | ||
| } | ||
| }, | ||
| None => vec!["ssl_version", "method"] |
There was a problem hiding this comment.
Upstream implementations checks for all calls at MEDIUM severity and the the specific functions at HIGH severity. Unsure if we want to replicate this, as it might be a bit heavy performance wise and Ruff/flake8-bandit has no way of separating the severity levels right now. Just copied upstream implementation for now
There was a problem hiding this comment.
I decided to reduce the rule scope for the same reason.
|
8f9e174
to
b3c05fc
Compare
charliermarsh
pushed a commit
that referenced
this pull request
Jan 5, 2024
## Summary Adds S503 rule for the [flake8-bandit](https://github.com/tylerwince/flake8-bandit) plugin port. Checks for function defs argument defaults which have an insecure ssl_version value. See also https://bandit.readthedocs.io/en/latest/_modules/bandit/plugins/insecure_ssl_tls.html#ssl_with_bad_defaults Some logic and the `const` can be shared with #9390. When one of the two is merged. ## Test Plan Fixture added ## Issue Link Refers: #1646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds S502 rule for the flake8-bandit plugin port.
Checks for calls to any function with keywords arguments
ssl_versionormethodor for kwargsmethodin calls toOpenSSL.SSL.Contextandssl_versionin calls tossl.wrap_socketwhich have an insecure ssl_version valu. See also https://bandit.readthedocs.io/en/latest/_modules/bandit/plugins/insecure_ssl_tls.html#ssl_with_bad_versionTest Plan
Fixture added
Issue Link
Refers: #1646