refactor: migrate auths-id and auths-core trust from anyhow to thiserror#11
Merged
refactor: migrate auths-id and auths-core trust from anyhow to thiserror#11
Conversation
…rror Define FreezeError, StorageError, and InitError enums in new error.rs module. Migrate all freeze.rs functions from anyhow::Result to FreezeError.
… thiserror Migrate IdentityStorage, AttestationSource, ReceiptStorage traits and all Git-backed implementations to use StorageError. Migrate helper functions in identity/helpers.rs to use IdentityError.
Migrate AttestationSink trait, encoders, load, export, and verify modules to use StorageError instead of anyhow::Result.
…from anyhow to thiserror
…om anyhow to thiserror
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auths-idfromanyhow::Resultto domain-specificthiserrorenums (FreezeError,StorageError,InitError). Removedanyhowfromauths-iddependencies entirely.auths-coretrust module (pinned.rs,roots_file.rs,continuity.rs,resolve.rs) fromanyhowto a newTrustErrorenum. Updated theKelContinuityCheckertrait signature.auths-storageadapters,auths-test-utilsfakes/mocks,auths-cliverify_attestationcollapsible_ifclippy warningsTest plan
cargo nextest run --workspace)cargo clippy --all-targets --all-features -- -D warningspassescargo fmt --check --allpassescd crates/auths-verifier && cargo check --target wasm32-unknown-unknown --no-default-features --features wasm)Notes
auths-core/src/api/runtime.rsstill usesanyhowinternally in macOS-gated SSH agent code — it doesn't leak to any public API, left for a follow-upcargo denyfailures (bannedreqwestviajsonschema) are pre-existing and unrelated to this PR