chore: clean up dead code, add rust docs to http crates#16
Merged
Conversation
Remove truly unused code (IncidentType, CommitReceiptPayload, tree_ops helpers, build_attributes, etc.), remove unnecessary annotations on actually-used items (CliError, visit_orgs), and add justifying comments on annotations that remain (serde targets, stub impls, feature-gated APIs).
Tests referenced the deleted CommitReceiptPayload struct. Also restore dead_code annotation on visit_orgs since it's only called from feature-gated code.
Add crate metadata (keywords, categories) to auths-sdk, auths-crypto, auths-telemetry, auths-storage, auths-infra-git, and auths-infra-http for crates.io discoverability.
Add //! doc blocks explaining purpose and listing public modules, following the pattern from auths-storage/src/lib.rs.
Add post_json method to RegistryClient trait and implement it in HttpRegistryClient. Refactor register_identity() to accept &impl RegistryClient instead of using reqwest directly. Update CLI callers to pass HttpRegistryClient. Remove reqwest dependency from auths-sdk and update deny.toml wrappers.
Add proptest-based tests for validate_kel() covering: - SAID integrity (recomputed SAID matches d field) - Duplicate/out-of-order sequence rejection - Broken chain detection (corrupted p field) - Multiple inception rejection - Wrong rotation key rejection (commitment mismatch) - Valid KEL replay idempotency - KEL with rotation replays correctly
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.