Conversation
…e.rs; move anyhow to dev-deps
…uths-core pattern
…tError::MutexError; remove blanket allow
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyhowfromauths-coreruntime dependencies; replaces the anyhow-based closure inregister_keys_with_macos_agent_internal()with a typedSshRegErrorenum — direct match, no downcastinglock().unwrap()calls inmemory.rs(MemoryKeychainHandle+IsolatedKeychainHandle) tomap_err(|_| AgentError::MutexError(...))and removes the module-level blanket#[allow]#[allow(clippy::unwrap_used, clippy::expect_used)]toauths-idtesting module (gap vsauths-corepattern)#[allow]sites in production code have inline justification commentsTest plan
cargo nextest run --workspace— 1567/1567 passcargo test --all --doc— 3 pass, 0 fail