chore(toolkit): default IoHost supports prompting #33177
+251
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
requested changes
Jan 27, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33177/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
597f187 to
efc836f
Compare
3f15b99 to
a48c67f
Compare
kaizencc
reviewed
Jan 29, 2025
a48c67f to
2bb3c0d
Compare
2bb3c0d to
72b8310
Compare
72b8310 to
15af140
Compare
15af140 to
4851da4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33177 +/- ##
==========================================
+ Coverage 80.79% 80.84% +0.05%
==========================================
Files 232 232
Lines 14106 14135 +29
Branches 2450 2460 +10
==========================================
+ Hits 11397 11428 +31
+ Misses 2429 2427 -2
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4851da4 to
67a8a8d
Compare
67a8a8d to
9690636
Compare
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
ClioIoHostdidn't implementrequestResponseproperly, it just returned the default value.However since this implementation is supposed to be exactly what the CLI does, we need to implement prompting.
Description of changes
Implements user prompting. This is not currently used yet by the CLI itself, we will enable this in follow-up ticket.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Added test cases.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license