feat(chart): Improved default security context#7279
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e211a98 to
0e90ebf
Compare
0e90ebf to
dacfc30
Compare
|
@tzneal could you take a look at this please? |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
dacfc30 to
5cc1c72
Compare
|
@jonathan-innis @tzneal could someone please take a look at this? |
5cc1c72 to
be44880
Compare
|
@jonathan-innis @tzneal could someone please take a look at this? |
|
I'll take a look at this. |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
be44880 to
144aa53
Compare
|
/not-stale |
144aa53 to
e351477
Compare
|
@saurav-agarwalla did you manage to take a look at this? |
|
@stevehipwell apologies for the delay, I started reviewing this but then got side-tracked with the holidays and other things. Planning to get back to it this week. |
Pull Request Test Coverage Report for Build 14513302984Details
💛 - Coveralls |
a81a0d6 to
35471b8
Compare
|
@saurav-agarwalla I think there is some confusion over what a first party Helm chart should be. A first party Helm chart should be opinionated and follow both industry and project best practices. As it owns the constraints it doesn't need to open everything up for customization. Karpenter's constraints are that it runs on Linux, as a non-root user, and doesn't need any additional OS permissions; therefore there is no valid reason to allow an end-user to lower this security posture. |
|
Hey @stevehipwell -- sorry that we've been slow on this -- I just took a look, most of the changes look reasonable -- just a few questions about potential breaking changes and why you need certain levels of customization |
35471b8 to
934ae1b
Compare
|
@jonathan-innis I've replied to your comments and rebased. |
b66b744 to
86b5dd8
Compare
|
@jonathan-innis I've reverted the pod non-root default. |
86b5dd8 to
6d4e9fa
Compare
|
@jonathan-innis I've rebased this PR again and it'd be great to get it merged. |
6d4e9fa to
439bdf8
Compare
|
I think that's my last question -- everything else looks good to ship -- just if there is a strong reason from removing RuntimeDefault |
6d4e9fa to
fa974a6
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
fa974a6 to
b24b786
Compare
|
@jonathan-innis could we get this merged before the release for v1.4.0? |
I think we're going to have to punt this into v1.5.0 at this point -- we've already staged out the changes for v1.4.0. I wouldn't expect us to have a huge lead time to the next minor version, though -- we've got a number of perf things that we'd like to get through and release soon-ish |
Fixes #N/A
Description
This PR improves the default security context posture and adds support for setting container values which should be user defined.
How was this change tested?
The Helm chart was templated with the new values.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.