Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented EKS_CONTROL_PLANE for version checking #7417

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Implemented EKS_CONTROL_PLANE for version checking #7417

merged 17 commits into from
Nov 25, 2024

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Implemented EKS_CONTROL_PLANE for version checking
How was this change tested?
make presubmit
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner November 21, 2024 01:20
@edibble21 edibble21 requested a review from danxwang22 November 21, 2024 01:20
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 16f6667
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6744e0452838c9000963fe3e

@coveralls
Copy link

coveralls commented Nov 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12018387051

Details

  • 40 of 63 (63.49%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-17.3%) to 65.106%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/operator/operator.go 0 5 0.0%
pkg/providers/version/version.go 25 33 75.76%
pkg/controllers/providers/version/controller.go 10 19 52.63%
Totals Coverage Status
Change from base Build 11999750352: -17.3%
Covered Lines: 5728
Relevant Lines: 8798
💛 - Coveralls

jmdeal
jmdeal reviewed Nov 21, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
pkg/fake/eksapi.go Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/version/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/version/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/version/suite_test.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Nov 24, 2024
View reviewed changes
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/options/options.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Nov 24, 2024
View reviewed changes
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/options/options.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
jmdeal
jmdeal reviewed Nov 25, 2024
View reviewed changes
pkg/operator/options/options.go Outdated Show resolved Hide resolved
pkg/controllers/providers/version/controller.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/operator/options/options.go Outdated Show resolved Hide resolved
pkg/providers/version/suite_test.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
jmdeal
jmdeal reviewed Nov 25, 2024
View reviewed changes
pkg/test/options.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
jmdeal
jmdeal approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 75d966a into aws:main Nov 25, 2024
17 checks passed
edibble21 added a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
@edibble21
Implemented EKS_CONTROL_PLANE for version checking (aws#7417)
a84ccb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@jmdeal jmdeal jmdeal approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edibble21 @coveralls @jmdeal @jonathan-innis