Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fixed termination test flake #7449

Merged
merged 5 commits into from
Nov 26, 2024
Merged

test: Fixed termination test flake #7449

merged 5 commits into from
Nov 26, 2024

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Fixed termination test flake
How was this change tested?
make e2etests
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edibble21 edibble21 requested a review from a team as a code owner November 26, 2024 18:53
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 541028f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67461e35f75aa300082d170a

@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12037488330

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.022%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 12037389893: -0.02%
Covered Lines: 5733
Relevant Lines: 8817
💛 - Coveralls

@edibble21 edibble21 changed the title Chore: Fixed termination test flake test: Fixed termination test flake Nov 26, 2024
jmdeal
jmdeal approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edibble21 edibble21 merged commit 9087a16 into aws:main Nov 26, 2024
17 checks passed
edibble21 added a commit to edibble21/karpenter-provider-aws that referenced this pull request Dec 2, 2024
@edibble21
test: Fixed termination test flake (aws#7449)
5f7889d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edibble21 @coveralls @jmdeal