Skip to content

Commit

Permalink
Starter fix (#403)
Browse files Browse the repository at this point in the history
* fix compile error

* update action config

* Update codeql-analysis.yml
  • Loading branch information
tullyliu authored Jan 26, 2025
1 parent b5f2562 commit 10d9de0
Show file tree
Hide file tree
Showing 85 changed files with 987 additions and 1,176 deletions.
18 changes: 12 additions & 6 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
permissions:
actions: read
contents: read
Expand All @@ -22,6 +22,7 @@ jobs:
fail-fast: false
matrix:
language: [ 'java' ]
java: [ '8', '17' ]

steps:
- name: Checkout repository
Expand All @@ -31,11 +32,11 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '8'
java-version: ${{ matrix.java }}

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}

Expand All @@ -47,12 +48,17 @@ jobs:
restore-keys: |
${{ runner.os }}-maven-
- name: Build
- name: Build starlight
if: ${{ matrix.java == '8' }}
run: |
mvn -B clean package -Dmaven.test.skip --file starlight/pom.xml --no-transfer-progress
- name: Build starlight-starter
if: ${{ matrix.java == '17' }}
run: |
mvn -B clean package -Dmaven.test.skip --file starlight/pom.xml --no-transfer-progress
mvn -B clean package -Dmaven.test.skip --file spring-cloud-starter-baidu-starlight/pom.xml --no-transfer-progress
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"
19 changes: 16 additions & 3 deletions .github/workflows/snapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
matrix:
java: [ '8', '17' ]
steps:
- name: Checkout project
uses: actions/checkout@v3
Expand All @@ -14,7 +17,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '8'
java-version: ${{ matrix.java }}
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
Expand All @@ -34,9 +37,19 @@ jobs:
restore-keys: |
${{ runner.os }}-maven-
- name: Publish Snaphot package
- name: Publish Snaphot package starlight
if: ${{ matrix.java == '8' }}
run: |
mvn -B deploy -P deploy -Dmaven.test.skip --file starlight/pom.xml --no-transfer-progress
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MAVEN_USERNAME: ${{ secrets.OSSRH_USER }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWD }}
MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSWD }}

- name: Publish Snaphot package starlight-starter
if: ${{ matrix.java == '17' }}
run: |
mvn -B deploy -P deploy -Dmaven.test.skip --file spring-cloud-starter-baidu-starlight/pom.xml --no-transfer-progress
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/starlight-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout project
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/starlight-starter-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout project
uses: actions/checkout@v3
Expand All @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '8'
java-version: '17'
server-id: ossrh
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
matrix:
java: [ '8', '17' ]
steps:
- name: Checkout project
uses: actions/checkout@v3
Expand All @@ -17,7 +20,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '8'
java-version: ${{ matrix.java }}

- name: Cache local Maven repository
uses: actions/cache@v3
Expand All @@ -27,9 +30,14 @@ jobs:
restore-keys: |
${{ runner.os }}-maven-
- name: Build
- name: Build starlight
if: ${{ matrix.java == '8' }}
run: |
mvn -B verify --file starlight/pom.xml --no-transfer-progress
- name: Build starlight-starter
if: ${{ matrix.java == '17' }}
run: |
mvn -B verify --file spring-cloud-starter-baidu-starlight/pom.xml --no-transfer-progress
- name: Upload Coverage Report
Expand Down
75 changes: 25 additions & 50 deletions spring-cloud-starter-baidu-starlight/pom.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
Expand All @@ -17,12 +18,12 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>
<java.version>17</java.version>
<spring-cloud.version>2022.0.0</spring-cloud.version>
<!-- plugin versions -->
<powermock.version>2.0.9</powermock.version>
<starlight.version>2024.0.2-SNAPSHOT</starlight.version>
<git-commit-id-plugin.version>2.2.5</git-commit-id-plugin.version>
<git-commit-id-plugin.version>2.2.5</git-commit-id-plugin.version>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -148,14 +149,14 @@
<artifactId>reflections</artifactId>
<version>0.10.2</version>
</dependency>
<dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-actuator</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
Expand Down Expand Up @@ -268,7 +269,7 @@
<tagNameFormat>starter-v@{project.version}</tagNameFormat>
</configuration>
</plugin>

<!--
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
Expand All @@ -282,16 +283,28 @@
</execution>
</executions>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.6.3</version>
<version>3.11.2</version>
<configuration>
<source>17</source>
<!-- 指定 JDK 版本 -->
<encoding>UTF-8</encoding>
<!-- 文档的编码 -->
<doclint>none</doclint>
<!-- 禁用文档校验 -->
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
<phase>package</phase>
<configuration>
<additionalJOptions>-Xdoclint:none</additionalJOptions>
</configuration>
</execution>
</executions>
</plugin>
Expand Down Expand Up @@ -323,45 +336,7 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>com.github.os72</groupId>
<artifactId>protoc-jar-maven-plugin</artifactId>
<version>3.6.0.1</version>
<executions>
<execution>
<id>generate-sources</id>
<phase>generate-sources</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<protocVersion>2.5.0</protocVersion>
<addSources>none</addSources>
<includeStdTypes>true</includeStdTypes>
<outputDirectory>src/main/java</outputDirectory>
<inputDirectories>
<include>src/main/proto</include>
</inputDirectories>
</configuration>
</execution>
<execution>
<id>generate-test-sources</id>
<phase>generate-test-sources</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<protocVersion>2.5.0</protocVersion>
<includeStdTypes>true</includeStdTypes>
<addSources>none</addSources>
<outputDirectory>src/test/java</outputDirectory>
<inputDirectories>
<include>src/test/proto</include>
</inputDirectories>
</configuration>
</execution>
</executions>
</plugin>

</plugins>
</build>
<url>https://github.com/baidu/starlight</url>
Expand Down Expand Up @@ -435,7 +410,7 @@
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.13</version>
<version>1.6.14</version>
<extensions>true</extensions>
<configuration>
<serverId>ossrh</serverId>
Expand Down
Loading

0 comments on commit 10d9de0

Please sign in to comment.