Add value for BLAKE3 hash function#248
Conversation
|
@EricBurnett mind taking a look at this? Thank you! |
|
LGTM! |
|
@tylerwilliams I was wondering, what's the reason you folks are pursuing using BLAKE3 and not the recently added SHA256TREE digest function (#235)? Sure, at its peak BLAKE3 is faster than SHA256TREE, but the difference isn't that big in the grand scheme of things, right? SHA256TREE has some added advantages:
I mean, I'm fine with adding support for BLAKE3, but I'm merely interested in seeing whether we can prevent Balkanization in this area. |
|
@EdSchouten -- Definitely agree re balkanization and I'm very excited to see SHA256TREE land for chunking support. We will likely support this too when it lands in Bazel :) That said, BLAKE3 is incredibly fast and this is useful when hashing large files, which we do a lot of (docker images, snapshots, large binaries, etc) on CPUs with AVX* support. I don't think it's a bad thing to support this hash in the protocol, or in Bazel, so that these kinds of blobs can be hashed quickly today. |
This is a follow up to bazelbuild#248 to ensure the git hook is running correctly.
This is a follow up to #248 to ensure the git hook is running correctly.
Add BLAKE3 hash function.