refactor: replace log with slog#36
Merged
DanielcoderX merged 1 commit intobepass-org:mainfrom Aug 31, 2023
Merged
Conversation
Rewrited the logger package and changed all of its references throughout the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the logger throughout the code is not a good idea and it turns your code into spaghetti code.
Now, Logger is a standalone package that works globally. You can use it like the slog package by importing it into any package.
And the new logger package is a wrapper around slog, and the exported functions are the same as before, so there are minimal code changes.