Skip to content

Conversation

@BD103
Copy link
Member

@BD103 BD103 commented Oct 9, 2024

This page was missing the date field, as helpfully pointed out by @TrialDragon. I filled it out based off the merge date of #1628.

While I was there, I also added the author field, since it was missing.

This will not fix the website not deploying, since there's an issue with the donation page, but it will silence the only other warning.

The actions without meeting page was missing the `date` field. I filled out the author field as well, as a drive-by change.
@BD103 BD103 added C-Bug A problem with the code that runs the site A-Foundation Donations, minutes and other bureaucracy S-Needs-Review D-Trivial labels Oct 9, 2024
@BD103
Copy link
Member Author

BD103 commented Oct 9, 2024

I also included a fix where the assets cache would not be found, but Bevy Assets would not be built. Because actions can only output strings, !steps.restore-cached-assets.outputs.cache-hit was always being resolved to false. (Because 'true' and 'false' are both non-empty strings.)

While what happened with previous CI runs has technically been fixed in actions/cache#1467 with actions/[email protected], this prevents further issues from happening in the future.

@cart cart added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bevyengine:main with commit bb90a62 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Foundation Donations, minutes and other bureaucracy C-Bug A problem with the code that runs the site D-Trivial S-Needs-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants