Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Conversation

@ZeroThe2nd
Copy link
Contributor

Changing the editor wasn't listed.
Using the env variable wouldn't work in production as env() calls will return null once the application's configuration has been cached.

  • Added a block to the README.MD file to list changing the used editor
  • Added a new config variable to credentials.php
  • Updated EditCredentialsCommand.php to use the config variable

Added some documentation to README.MD on how to change the underlying used CLI editor
- Added 'editor' to credentials.php
- Updated the EditCredentialsCommand to use the config value
@mpociot mpociot merged commit 417c66e into beyondcode:master Oct 16, 2020
@mpociot
Copy link
Member

mpociot commented Oct 16, 2020

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants