Repository navigation
Fixed multiple issues with configuration of Legacy API on 0.x branch - #96
Conversation
There was a problem hiding this comment.
We should keep the original method name for backward compatibility, we should definitely update the readme with this, sorry for the confusion!
There was a problem hiding this comment.
Sure. I will make that change and update the README to reflect it. The only reason I suggested this change was because, it will be more inline with how @configuration is setup and also this is the way it was mentioned in README with the key :verify_ssl.
|
I am more than willing to make some changes on the readme to reflect the changes we discussed. I think the strategy should be that we update the README, make some of the functional code changes, then cut a new release. Let me know how I can help :). |
|
@pedelman Thank you for all the help :) |
There was a problem hiding this comment.
Is this needed? The default for rest client is to enable peer, and if you want to disable it, you can just use the :verify_peer?
There was a problem hiding this comment.
Yes, I tested the code with only :verify_ssl => @configuration[:verify_ssl]. In the case, where :verify_peer is not passed in API config, @configuration[:verify_ssl] would return nil and RestClient treats it as OpenSSL::SSL::VERIFY_NONE. That's the reason for adding || OpenSSL::SSL::VERIFY_PEER part.
|
@pedelman I have updated the code and README to include the new key |
There was a problem hiding this comment.
one quick typo here, environment
|
Can you please rebase these commits and fix that typo. I think once that is done this should be good to go! Thanks a bunch! |
|
@pedelman I have fixed the typo. As for the rebase goes, I am little concerned as when I originally forked I made changes in "master" branch and at that time there were no separate versions(0.x and rewrite one). Now you have two branches, how do I rebase, could you please guide me with steps to proceed from here. |
|
In your case, you aren't doing a You will do something like the following: git rebase -i HEAD~7This will launch you into an interactive rebase view where you can pick which commits you want. In your case, you will want to squash all the commits together, update the commit message, then force push that to your fork/branch. |
1 similar comment
|
@pedelman Thank you for the guidance. Followed accordingly, its good to go. |
|
Hey @pedelman, why has this been sitting around for so long? |
Moving the changes specified in PR #88 from master to 0.x branch.