Skip to content

Fixed multiple issues with configuration of Legacy API on 0.x branch - #96

Merged
pedelman merged 1 commit into
bigcommerce:0.xfrom
kirtithorat:master
Jun 20, 2016
Merged

pedelman merged 1 commit into
bigcommerce:0.xfrom
kirtithorat:master

Conversation

@kirtithorat

Copy link
Copy Markdown

Moving the changes specified in PR #88 from master to 0.x branch.

Comment thread lib/bigcommerce/connection.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the original method name for backward compatibility, we should definitely update the readme with this, sorry for the confusion!

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will make that change and update the README to reflect it. The only reason I suggested this change was because, it will be more inline with how @configuration is setup and also this is the way it was mentioned in README with the key :verify_ssl.

@pedelman

Copy link
Copy Markdown
Contributor

I am more than willing to make some changes on the readme to reflect the changes we discussed.

I think the strategy should be that we update the README, make some of the functional code changes, then cut a new release. Let me know how I can help :).

@kirtithorat

Copy link
Copy Markdown
Author

@pedelman Thank you for all the help :)
I went ahead and made the changes suggested by you. Let me know your thoughts on those.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.05%) to 61.72% when pulling 4204885 on kirtithorat:master into 095245a on bigcommerce:0.x.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? The default for rest client is to enable peer, and if you want to disable it, you can just use the :verify_peer?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tested the code with only :verify_ssl => @configuration[:verify_ssl]. In the case, where :verify_peer is not passed in API config, @configuration[:verify_ssl] would return nil and RestClient treats it as OpenSSL::SSL::VERIFY_NONE. That's the reason for adding || OpenSSL::SSL::VERIFY_PEER part.

@kirtithorat

Copy link
Copy Markdown
Author

@pedelman I have updated the code and README to include the new key ssl_client. Let me know what you think

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick typo here, environment

@pedelman

Copy link
Copy Markdown
Contributor

Can you please rebase these commits and fix that typo. I think once that is done this should be good to go! Thanks a bunch!

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.31%) to 61.46% when pulling da21084 on kirtithorat:master into 095245a on bigcommerce:0.x.

@kirtithorat

Copy link
Copy Markdown
Author

@pedelman I have fixed the typo. As for the rebase goes, I am little concerned as when I originally forked I made changes in "master" branch and at that time there were no separate versions(0.x and rewrite one). Now you have two branches, how do I rebase, could you please guide me with steps to proceed from here.

@pedelman

pedelman commented Apr 1, 2015

Copy link
Copy Markdown
Contributor

@kirtithorat

In your case, you aren't doing a pull --rebase on master, doing so would give you a ton of changes 😄

You will do something like the following:

git rebase -i HEAD~7

This will launch you into an interactive rebase view where you can pick which commits you want. In your case, you will want to squash all the commits together, update the commit message, then force push that to your fork/branch.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.31%) to 61.46% when pulling 0f9ae1c on kirtithorat:master into 095245a on bigcommerce:0.x.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.31%) to 61.46% when pulling 0f9ae1c on kirtithorat:master into 095245a on bigcommerce:0.x.

@kirtithorat

Copy link
Copy Markdown
Author

@pedelman Thank you for the guidance. Followed accordingly, its good to go.

@gabelimon

Copy link
Copy Markdown

Hey @pedelman, why has this been sitting around for so long?

@pedelman
pedelman merged commit 42f5879 into bigcommerce:0.x Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants