This repository was archived by the owner on Mar 9, 2026. It is now read-only.
Add VENTILATION climateControlState#648
Merged
rikroe merged 1 commit intobimmerconnected:masterfrom Aug 24, 2024
DatDraggy:master
Merged
Add VENTILATION climateControlState#648rikroe merged 1 commit intobimmerconnected:masterfrom DatDraggy:master
rikroe merged 1 commit intobimmerconnected:masterfrom
DatDraggy:master
Conversation
Contributor
Author
|
Is a dedicated test necessary? I tested it locally and it displays fine, just the translation is missing for HA. |
Contributor
Author
Member
|
Many thanks! HA translation will need to be adjusted once the lib update gets merged. |
rikroe
approved these changes
Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
There currently is no constant to reflect the "VENTILATION" state, resulting in it defaulting to "Unknown". It's the climatization function that's toggleable via the api while the car is off.
Type of change
Additional information
Currently there's no translation for VENTILATION, I'm new to contributions so I'm unsure if this is on the HA translation team or if this is something I have to add somewhere.
Checklist