Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always raise MyBMWAuthError during login #650

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Aug 24, 2024

Proposed change

Always raise MyBMWAuthError when a HTTP error occurs during authentication.

This should solve retry loops due to quota issues like here and trigger the HA reauthentication flow (stopping retries).

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe force-pushed the always-raise-autherror branch from 0fef190 to bb02942 Compare August 24, 2024 15:05
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ef3db68) to head (51b0641).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1428      1418   -10     
=========================================
- Hits          1428      1418   -10     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (ø)
3.12 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikroe rikroe merged commit a7e91d4 into bimmerconnected:master Aug 24, 2024
13 checks passed
@rikroe rikroe deleted the always-raise-autherror branch December 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant