Add tests for pagination

bitfield · Aug 15, 2019 · 246b3dd · 246b3dd
1 parent 7711ffd
commit 246b3dd
Show file tree

Hide file tree

Showing 4 changed files with 2,473 additions and 1 deletion.
diff --git a/pkg/client.go b/pkg/client.go
@@ -97,6 +97,7 @@ func (c *Client) GetMonitor(ID int64) (Monitor, error) {
 	return r.Monitors[0], nil
 }
 
+// PageLimit is the default limit for monitors returned per page.
 const PageLimit = 50
 
 // AllMonitors returns a slice of Monitors representing the monitors currently
@@ -129,7 +130,8 @@ func (c *Client) AllMonitors() (monitors []Monitor, err error) {
 
 		offset = r.Pagination.Offset + limit
 		total := r.Pagination.Total
-		loopCondition = (offset+limit < total)
+
+		loopCondition = offset < total
 	}
 
 	return monitors, err