This repository was archived by the owner on Sep 14, 2020. It is now read-only.
Fix for Delimiter must not be alphanumeric or backslash when running …#260
Open
WinstonN wants to merge 1 commit intoblmage:0.9.0from
Open
Fix for Delimiter must not be alphanumeric or backslash when running …#260WinstonN wants to merge 1 commit intoblmage:0.9.0from
WinstonN wants to merge 1 commit intoblmage:0.9.0from
Conversation
Author
|
@mage-eag can you please have a look at this and let me know if this change won't break stuff. It works for me, but I'm not sure why you used preg_match vs strpos in the first place |
|
@WinstonN Your change won't work properly anyway, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Mage on hhvm
I am running Magento 1.8.1.0 CE on HipHop VM 3.11.0 (rel) and I get the following error on a grid running a custom grid. This change fixes the error