(#25 #26) ActivityScene TotalView 연결 및 Date PickerView 구현#103
Merged
(#25 #26) ActivityScene TotalView 연결 및 Date PickerView 구현#103
Conversation
whrlgus
reviewed
Dec 8, 2020
|
|
||
| class ActivityDateFilterViewController: UIViewController { | ||
| private lazy var backgroundView = UIView() | ||
| private lazy var sheetView = DateFilterSheetView( |
whrlgus
reviewed
Dec 8, 2020
|
|
||
| import UIKit | ||
|
|
||
| class DateFilterSheetView: UIScrollView { |
Collaborator
Author
There was a problem hiding this comment.
저희 goalTypeSheet과는 다르게 TabBar가 보이면서 올라오는 환경인데
코디네이터 상에서 탭바 위로 화면을 띄우려먼 너무 번거로운작업을 거쳐야 해서
FilterSheet의 높이를 키워서 띄우는 화면을 구현하였는데
스크롤뷰를 사용 안하면 높이를 키울때 그 안에있는 자식 뷰들과의 위치관계가 어색해지기 때문에
실제로 올라오는것처럼 보이기 위해 스크롤 뷰를 사용했습니다.
whrlgus
reviewed
Dec 8, 2020
| } | ||
| } | ||
|
|
||
| func selfResizing() { |
Collaborator
There was a problem hiding this comment.
아래 두 메소드 호출을 안하면 무슨 일이 벌어지나요?
Collaborator
There was a problem hiding this comment.
그 아래에서 frame 변경하는 부분은 frame.size.height = height 이렇게만 해주면 안되나요?
whrlgus
approved these changes
Dec 8, 2020
seoulboy
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Close #94 #93 #101
변경사항
주입받아 상단에 표시하도록 함
또한 height를 조절하면 내부의 View들의 레이아웃이 깨지게 되므로 UIScrollView를 상속받아 구현
를 주입받아 FilterType에 따라 PickerView에서 다르게 표시되도록 구현
새로운 기능
작업 유형
체크리스트