Skip to content

Commit

Permalink
Crossref Unixref XML: Fix reference book with 'other' component type
Browse files Browse the repository at this point in the history 
https://forums.zotero.org/discussion/93679/incorrect-entry-for-encyclopedia-entry-book-chapter-from-doi

Allow a `componentType` of `other` when the `bookType` is `reference`.
If the `bookType` is `other`, accept only `chapter` or `reference_type`
as before. Not sure whether an `other`/`other` edited book would be
possible, but this seems safer.
  • Loading branch information
@dstillman
dstillman committed Dec 29, 2021
1 parent 493c481 commit 266e5ad
Showing 1 changed file with 43 additions and 7 deletions.
50 changes: 43 additions & 7 deletions Crossref Unixref XML.js
View file
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
{
"translatorID": "93514073-b541-4e02-9180-c36d2f3bb401",
"translatorType": 1,
"label": "Crossref Unixref XML",
"creator": "Sebastian Karcher",
"target": "xml",
"minVersion": "3.0",
"maxVersion": null,
"maxVersion": "",
"priority": 100,
"inRepository": true,
"browserSupport": "gcsibv",
"configOptions": {
"dataMode": "xml/dom"
},
"lastUpdated": "2021-07-15 09:33:14"
"inRepository": true,
"translatorType": 1,
"lastUpdated": "2021-12-29 19:43:47"
}

/*
Expand Down Expand Up @@ -238,8 +237,10 @@ function doImport() {
var bookType = itemXML[0].hasAttribute("book_type") ? itemXML[0].getAttribute("book_type") : null;
var componentType = ZU.xpathText(itemXML[0], 'content_item/@component_type');
// is this an entry in a reference book?
var isReference = ["reference", "other"].includes(bookType)
&& ["chapter", "reference_entry"].includes(componentType);
var isReference = (bookType == "reference"
&& ["chapter", "reference_entry", "other"].includes(componentType))
|| (bookType == "other"
&& ["chapter", "reference_entry"].includes(componentType));

// for items that are entry in reference books OR edited book types that have some type of a chapter entry.
if ((bookType === "edited_book" && componentType) || isReference) {
Expand Down Expand Up @@ -714,6 +715,41 @@ var testCases = [
"seeAlso": []
}
]
},
{
"type": "import",
"input": "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<doi_records>\n <doi_record owner=\"10.1002\" timestamp=\"2020-10-06 16:52:28\">\n <crossref>\n <book book_type=\"reference\">\n <book_metadata language=\"en\">\n <contributors>\n <person_name contributor_role=\"editor\" sequence=\"first\">\n <given_name>Jan</given_name>\n <surname>Bulck</surname>\n </person_name>\n </contributors>\n <titles>\n <title>The International Encyclopedia of Media Psychology</title>\n </titles>\n <edition_number>1</edition_number>\n <publication_date media_type=\"online\">\n <month>09</month>\n <day>08</day>\n <year>2020</year>\n </publication_date>\n <isbn media_type=\"electronic\">9781119011071</isbn>\n <publisher>\n <publisher_name>Wiley</publisher_name>\n </publisher>\n <publisher_item>\n <identifier id_type=\"doi\">10.1002/9781119011071</identifier>\n </publisher_item>\n <program name=\"AccessIndicators\">\n <license_ref applies_to=\"tdm\">http://doi.wiley.com/10.1002/tdm_license_1.1</license_ref>\n </program>\n <doi_data>\n <doi>10.1002/9781119011071</doi>\n <timestamp>2020100613475700320</timestamp>\n <resource>https://onlinelibrary.wiley.com/doi/book/10.1002/9781119011071</resource>\n </doi_data>\n </book_metadata>\n <content_item component_type=\"other\" level_sequence_number=\"1\" publication_type=\"full_text\">\n <contributors>\n <person_name contributor_role=\"author\" sequence=\"first\">\n <given_name>Allison</given_name>\n <surname>Eden</surname>\n </person_name>\n </contributors>\n <titles>\n <title>Appreciation and Eudaimonic Reactions to Media</title>\n </titles>\n <publication_date media_type=\"online\">\n <month>09</month>\n <day>09</day>\n <year>2020</year>\n </publication_date>\n <pages>\n <first_page>1</first_page>\n <last_page>9</last_page>\n </pages>\n <publisher_item>\n <identifier id_type=\"doi\">10.1002/9781119011071.iemp0172</identifier>\n </publisher_item>\n <archive_locations>\n <archive name=\"Portico\" />\n </archive_locations>\n <program name=\"AccessIndicators\">\n <license_ref applies_to=\"tdm\">http://doi.wiley.com/10.1002/tdm_license_1.1</license_ref>\n </program>\n <doi_data>\n <doi>10.1002/9781119011071.iemp0172</doi>\n <timestamp>2020100613475700320</timestamp>\n <resource>https://onlinelibrary.wiley.com/doi/10.1002/9781119011071.iemp0172</resource>\n <collection property=\"crawler-based\">\n <item crawler=\"iParadigms\">\n <resource>https://onlinelibrary.wiley.com/doi/pdf/10.1002/9781119011071.iemp0172</resource>\n </item>\n </collection>\n <collection property=\"text-mining\">\n <item>\n <resource mime_type=\"application/pdf\">https://onlinelibrary.wiley.com/doi/pdf/10.1002/9781119011071.iemp0172</resource>\n </item>\n <item>\n <resource mime_type=\"application/xml\">https://onlinelibrary.wiley.com/doi/full-xml/10.1002/9781119011071.iemp0172</resource>\n </item>\n </collection>\n </doi_data>\n <citation_list>\n <citation key=\"e_1_2_9_1_2_1\">\n <doi>10.1080/15213269.2016.1182030</doi>\n </citation>\n <citation key=\"e_1_2_9_1_3_1\">\n <doi>10.1080/23736992.2017.1329019</doi>\n </citation>\n <citation key=\"e_1_2_9_1_4_1\">\n <doi>10.1111/jcom.12228</doi>\n </citation>\n <citation key=\"e_1_2_9_1_5_1\">\n <doi>10.1080/10510974.2017.1340903</doi>\n </citation>\n <citation key=\"e_1_2_9_1_6_1\">\n <doi>10.1111/jcom.12101</doi>\n </citation>\n <citation key=\"e_1_2_9_1_7_1\">\n <doi>10.1080/15205436.2013.872277</doi>\n </citation>\n <citation key=\"e_1_2_9_1_8_1\">\n <doi>10.1111/j.1468-2958.2009.01368.x</doi>\n </citation>\n <citation key=\"e_1_2_9_1_9_1\">\n <doi>10.1027/1864-1105/a000029</doi>\n </citation>\n <citation key=\"e_1_2_9_1_10_1\">\n <doi>10.1037/ppm0000066</doi>\n </citation>\n <citation key=\"e_1_2_9_1_11_1\">\n <doi>10.1111/j.1460-2466.2011.01585.x</doi>\n </citation>\n <citation key=\"e_1_2_9_1_12_1\">\n <volume_title>The role of intuition accessibility on the appraisal and selection of media content</volume_title>\n <author>Prabhu S.</author>\n <cYear>2014</cYear>\n </citation>\n <citation key=\"e_1_2_9_1_13_1\">\n <doi>10.1080/15213269.2013.773494</doi>\n </citation>\n <citation key=\"e_1_2_9_1_14_1\">\n <doi>10.1111/j.1460-2466.2012.01649.x</doi>\n </citation>\n <citation key=\"e_1_2_9_1_15_1\">\n <doi>10.1111/jcom.12099</doi>\n </citation>\n <citation key=\"e_1_2_9_1_16_1\">\n <doi>10.1111/jcom.12097</doi>\n </citation>\n <citation key=\"e_1_2_9_1_17_1\">\n <doi>10.1111/jcom.12100</doi>\n </citation>\n <citation key=\"e_1_2_9_1_18_1\">\n <doi>10.1027/1864-1105/a000031</doi>\n </citation>\n <citation key=\"e_1_2_9_1_19_1\">\n <volume_title>Sage handbook of media processes and effects</volume_title>\n <author>Vorderer P.</author>\n <first_page>455</first_page>\n <cYear>2009</cYear>\n </citation>\n <citation key=\"e_1_2_9_1_20_1\">\n <doi>10.1111/j.1468-2958.2012.01434.x</doi>\n </citation>\n <citation key=\"e_1_2_9_1_21_1\">\n <doi>10.1177/000276488031003005</doi>\n </citation>\n <citation key=\"e_1_2_9_2_2_1\">\n <doi>10.1080/15213260701813447</doi>\n </citation>\n <citation key=\"e_1_2_9_2_3_1\">\n <volume_title>Thinking, fast and slow</volume_title>\n <author>Kahneman D.</author>\n <cYear>2011</cYear>\n </citation>\n <citation key=\"e_1_2_9_2_4_1\">\n <doi>10.1093/joc/jqx020</doi>\n </citation>\n </citation_list>\n </content_item>\n </book>\n </crossref>\n </doi_record>\n</doi_records>",
"items": [
{
"itemType": "bookSection",
"title": "Appreciation and Eudaimonic Reactions to Media",
"creators": [
{
"creatorType": "editor",
"firstName": "Jan",
"lastName": "Bulck"
},
{
"creatorType": "author",
"firstName": "Allison",
"lastName": "Eden"
}
],
"date": "2020-09-09",
"ISBN": "9781119011071",
"bookTitle": "The International Encyclopedia of Media Psychology",
"edition": "1",
"extra": "DOI: 10.1002/9781119011071.iemp0172",
"language": "en",
"pages": "1-9",
"publisher": "Wiley",
"url": "https://onlinelibrary.wiley.com/doi/10.1002/9781119011071.iemp0172",
"attachments": [],
"tags": [],
"notes": [],
"seeAlso": []
}
]
}
]
/** END TEST CASES **/

0 comments on commit 266e5ad

Please sign in to comment.