add basic column tests for arrays and update readme#273
Closed
ilkernator wants to merge 1 commit intocalogica:mainfrom
Closed
add basic column tests for arrays and update readme#273ilkernator wants to merge 1 commit intocalogica:mainfrom
ilkernator wants to merge 1 commit intocalogica:mainfrom
Conversation
Contributor
|
Hi, thanks for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue this PR Addresses/Closes
#272
Summary of Changes
Added two new tests to the "column_values_basic" directory and updated the readme-file:
Why Do We Need These Changes
For tables that contain columns of type
arrayorarray(struct), the values can be sometimes empty without being NULL (e.g.[ ], or[" "]. In this case, the test to expect_column_values_to_not_be_null.sql could be misleading and mask the issue of having empty values. So we would need to make use of Hive functions to assert the array is indeed empty.Reviewers
@clausherther