Skip to content

Conversation

@jurgenwerk
Copy link
Contributor

@jurgenwerk jurgenwerk commented Dec 30, 2025

image image

@github-actions
Copy link

Preview deployments

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Host Test Results

    1 files  ±    0      1 suites  ±0   3h 13m 0s ⏱️ + 1h 40m 16s
1 852 tests +   85  1 837 ✅ +   84  14 💤 + 1  1 ❌ ±0 
3 728 runs  +1 944  3 699 ✅ +1 929  28 💤 +15  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit f726aa5. ± Comparison against base commit 5a12304.

This pull request removes 1 and adds 86 tests. Note that renamed tests count towards both.
Chrome ‑ Global error: Uncaught ChunkLoadError: Loading chunk node_modules_pnpm_monaco-editor_0_52_2_patch_hash_a09898c89392828a4df910a8b4b952fd774a69b7799-496838 failed. (error: http://localhost:7357/assets/chunk.0f5bd3ad30dee9fefedf.js) at http://localhost:7357/assets/chunk.5350f71d1cbc6593dffe.js, line 153748  While executing test: Acceptance | code-submode | field playground > single realm: can preview compound field instance 
Chrome ‑ Acceptance | Freestyle: smoke check
Chrome ‑ Acceptance | code-submode | field playground > multiple realms: can autogenerate new Spec and field instance (no preexisting Spec)
Chrome ‑ Acceptance | code-submode | field playground > multiple realms: can autogenerate new field instance when spec exists but has no examples
Chrome ‑ Acceptance | code-submode | field playground > multiple realms: can create new field instance (has preexisting Spec)
Chrome ‑ Acceptance | code-submode | field playground > single realm: can autogenerate new Spec and field instance (no preexisting Spec)
Chrome ‑ Acceptance | code-submode | field playground > single realm: can autogenerate new field instance when spec exists but has no examples
Chrome ‑ Acceptance | code-submode | field playground > single realm: can create new field instance (has preexisting Spec)
Chrome ‑ Acceptance | code-submode | field playground > single realm: can not preview non-exports or primitives
Chrome ‑ Acceptance | code-submode | field playground > single realm: can populate instance chooser dropdown options with containedExamples from Spec
Chrome ‑ Acceptance | code-submode | field playground > single realm: can preview compound field instance
…

♻️ This comment has been updated with latest results.

@jurgenwerk jurgenwerk marked this pull request as ready for review December 31, 2025 11:49
@jurgenwerk jurgenwerk requested a review from Copilot December 31, 2025 11:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the UI to make correctness check commands appear as part of the previous card/code patching message, creating a more integrated and less technical user experience. The changes hide technical terminology like "correctness checks" from user-facing messages and introduce a compact visual mode for these follow-up validation messages.

  • Modified AI prompts to avoid exposing technical terms like "correctness checks" to users, replacing with user-friendly language
  • Introduced a compact display mode for code patch correctness messages with reduced spacing, hidden metadata, and streamlined controls
  • Updated styling across multiple components to support the compact mode with flexbox layout adjustments and CSS custom properties

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/runtime-common/ai/prompt.ts Updated prompt instructions to use more user-friendly language, replacing technical terms like "correctness checks" with "validation" and instructing the AI to avoid mentioning automated checks
packages/host/app/components/matrix/room-message.gts Added isCodePatchCorrectness property propagation to enable compact mode for correctness check messages
packages/host/app/components/matrix/room-message-command.gts Integrated isCompact parameter throughout the component and applied it to code blocks and command headers
packages/host/app/components/ai-assistant/message/index.gts Added code-patch-correctness CSS class and styling to reduce spacing between consecutive compact commands
packages/host/app/components/ai-assistant/code-block/view-code-button.gts Added compact mode styling with adjusted sizing and positioning for info button
packages/host/app/components/ai-assistant/code-block/index.gts Added compact mode styling to remove background and borders for a more integrated appearance
packages/host/app/components/ai-assistant/code-block/command-header.gts Implemented compact header layout with flexbox, hidden copy button, and ellipsized command description
packages/host/app/components/ai-assistant/apply-button/index.gts Added comprehensive compact mode styling with reduced dimensions and state-specific adjustments
packages/ai-bot/tests/prompt-construction-test.ts Updated test to match the new prompt message format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

role: 'user',
content:
'The automated correctness checks have finished. Summarize their results for me based on the tool output above.',
'The automated correctness checks have finished. Summarize the results based on the tool output above in one short sentence. Do not mention: correctness, automated correctness checks, tool calls.',
Copy link

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user-facing prompt message still contains "automated correctness checks" while also instructing the AI not to mention it. This is contradictory and inconsistent with the PR's goal of hiding this terminology from users. Consider rewording to something like: "The automated validation has finished. Summarize the results based on the tool output above in one short sentence. Do not mention: correctness, automated correctness checks, tool calls."

Suggested change
'The automated correctness checks have finished. Summarize the results based on the tool output above in one short sentence. Do not mention: correctness, automated correctness checks, tool calls.',
'The automated validation has finished. Summarize the results based on the tool output above in one short sentence. Do not mention: validation, tool calls.',

Copilot uses AI. Check for mistakes.
@jurgenwerk jurgenwerk requested a review from a team December 31, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants