Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed download after major changes at laracasts #75

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fixed download after major changes at laracasts #75

merged 1 commit into from
Nov 12, 2018

Conversation

storrella
Copy link

Fixes #74

After laracasts recent changes, lessons and series cannot be crawled anymore because now that info is loaded via xhr requests through Algolia API. I switched the crawler with an Angolia client and updated README with new intructions.

The ALGOLIA_APP_ID and ALGOLIA_API_KEY env variables must be filled manually.

It would be nice if someone does another pr crawling them from the js files

@myself379
Copy link

I tested by following your instruction in your updated README.md and its working.

@carlosflorencio
Copy link
Owner

Great work @storrella, thanks for your effort. 💪

Since I can't test it myself, I'll wait for some more feedback before merging.

@cerberos
Copy link

Thank you @storrella for the commit, it works perfectly now. And a big thank you to @carlosflorencio.

@carlosflorencio carlosflorencio merged commit 1c6a70f into carlosflorencio:master Nov 12, 2018
@carlosflorencio
Copy link
Owner

Thanks @storrella. 💪

@ghost
Copy link

ghost commented Nov 28, 2018

Having a little trouble getting the key and id. I get the following;

o = "x-algolia-api-key" === r || "x-algolia-application-id" === r ? "hidden for security purposes" : e[r], t[r] = o

Any recommendations for getting these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants