Skip to content

Pushover Delivery Group Support#1563

Open
caronc wants to merge 1 commit intomasterfrom
980-pushover-delivery-groups
Open

Pushover Delivery Group Support#1563
caronc wants to merge 1 commit intomasterfrom
980-pushover-delivery-groups

Conversation

@caronc
Copy link
Copy Markdown
Owner

@caronc caronc commented Mar 29, 2026

Description

Related issue (if applicable): #980

Added support for Pushover Delivery Groups

Checklist

  • Documentation ticket created (if applicable): apprise-docs/26
  • The change is tested and works locally.
  • No commented-out code in this PR.
  • No lint errors (use tox -e lint and optionally tox -e format).
  • Test coverage added or updated (use tox -e qa).

Testing

Anyone can help test as follows:

# Create a virtual environment
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@980-pushover-delivery-groups

# If you have cloned the branch and have tox available to you:
tox -e apprise -- -t "Test Title" -b "Test Message" \
    'pover://credentials/#group/#group2'

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2b47159) to head (7640814).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1563   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        25829     25847   +18     
  Branches      4205      4210    +5     
=========================================
+ Hits         25829     25847   +18     
Files with missing lines Coverage Δ
apprise/plugins/pushover.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for Pushover “Delivery Groups” so Apprise users can target #groupKey in addition to (or alongside) device targets.

Changes:

  • Added parsing/validation for group targets (prefixed with # / %23) and updated URL parsing to preserve literal # in the path.
  • Updated notification sending to fan out as: one request for all devices (batched) plus one request per group key.
  • Expanded the Pushover plugin test suite to include group URL parsing and edge cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
apprise/plugins/pushover.py Adds group target support, adjusts URL parsing/serialization, and changes send() behavior to support per-group requests.
tests/test_plugin_pushover.py Adds URL and edge-case coverage for group targets and updates assertions for new internal target tracking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants