Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1563 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 196 196
Lines 25829 25847 +18
Branches 4205 4210 +5
=========================================
+ Hits 25829 25847 +18
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds support for Pushover “Delivery Groups” so Apprise users can target #groupKey in addition to (or alongside) device targets.
Changes:
- Added parsing/validation for group targets (prefixed with
#/%23) and updated URL parsing to preserve literal#in the path. - Updated notification sending to fan out as: one request for all devices (batched) plus one request per group key.
- Expanded the Pushover plugin test suite to include group URL parsing and edge cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
apprise/plugins/pushover.py |
Adds group target support, adjusts URL parsing/serialization, and changes send() behavior to support per-group requests. |
tests/test_plugin_pushover.py |
Adds URL and edge-case coverage for group targets and updates assertions for new internal target tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue (if applicable): #980
Added support for Pushover Delivery Groups
Checklist
tox -e lintand optionallytox -e format).tox -e qa).Testing
Anyone can help test as follows: